Messages in this thread | | | Subject | Re: [PATCH net v2] hinic: fix a bug of ndo_stop | From | "luobin (L)" <> | Date | Mon, 11 May 2020 10:09:14 +0800 |
| |
Will fix. Thanks.
On 2020/5/10 6:37, Jakub Kicinski wrote: > On Fri, 8 May 2020 20:19:33 +0000 Luo bin wrote: >> if some function in ndo_stop interface returns failure because of >> hardware fault, must go on excuting rest steps rather than return >> failure directly, otherwise will cause memory leak.And bump the >> timeout for SET_FUNC_STATE to ensure that cmd won't return failure >> when hw is busy. Otherwise hw may stomp host memory if we free >> memory regardless of the return value of SET_FUNC_STATE. >> >> Signed-off-by: Luo bin <luobin9@huawei.com> > Doesn't apply to the net tree: > > error: patch failed: drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c:353 > error: drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c: patch does not apply > error: patch failed: drivers/net/ethernet/huawei/hinic/hinic_main.c:504 > error: drivers/net/ethernet/huawei/hinic/hinic_main.c: patch does not apply > hint: Use 'git am --show-current-patch' to see the failed patch > Applying: hinic: fix a bug of ndo_stop > > Please also include a Fixes tag when you repost. > .
| |