Messages in this thread | | | Date | Fri, 1 May 2020 15:40:50 +0000 | From | Luis Chamberlain <> | Subject | Re: [PATCH v3 5/6] blktrace: break out of blktrace setup on concurrent calls |
| |
On Fri, May 01, 2020 at 08:34:23AM -0700, Christoph Hellwig wrote: > On Fri, May 01, 2020 at 03:06:26PM +0000, Luis Chamberlain wrote: > > > You have access to a block device here, please use dev_warn() instead > > > here for that, that makes it obvious as to what device a "concurrent > > > blktrace" was attempted for. > > > > The block device may be empty, one example is for scsi-generic, but I'll > > use buts->name. > > Is blktrace on /dev/sg something we intentionally support, or just by > some accident of history? Given all the pains it causes I'd be tempted > to just remove the support and see if anyone screams.
From what I can tell I think it was a historic and brutal mistake. I am more than happy to remove it.
Re-adding support would just be a symlink.
Luis
| |