lkml.org 
[lkml]   [2020]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 71/83] ext4: use matching invalidatepage in ext4_writepage
    Date
    From: yangerkun <yangerkun@huawei.com>

    [ Upstream commit c2a559bc0e7ed5a715ad6b947025b33cb7c05ea7 ]

    Run generic/388 with journal data mode sometimes may trigger the warning
    in ext4_invalidatepage. Actually, we should use the matching invalidatepage
    in ext4_writepage.

    Signed-off-by: yangerkun <yangerkun@huawei.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
    Reviewed-by: Jan Kara <jack@suse.cz>
    Link: https://lore.kernel.org/r/20200226041002.13914-1-yangerkun@huawei.com
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/ext4/inode.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
    index b9473fcc110fd..7e0c77de551bb 100644
    --- a/fs/ext4/inode.c
    +++ b/fs/ext4/inode.c
    @@ -2131,7 +2131,7 @@ static int ext4_writepage(struct page *page,
    bool keep_towrite = false;

    if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) {
    - ext4_invalidatepage(page, 0, PAGE_SIZE);
    + inode->i_mapping->a_ops->invalidatepage(page, 0, PAGE_SIZE);
    unlock_page(page);
    return -EIO;
    }
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-05-01 15:50    [W:3.325 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site