lkml.org 
[lkml]   [2020]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 010/117] ceph: return ceph_mdsc_do_request() errors from __get_parent()
    Date
    From: Qiujun Huang <hqjagain@gmail.com>

    [ Upstream commit c6d50296032f0b97473eb2e274dc7cc5d0173847 ]

    Return the error returned by ceph_mdsc_do_request(). Otherwise,
    r_target_inode ends up being NULL this ends up returning ENOENT
    regardless of the error.

    Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
    Reviewed-by: Jeff Layton <jlayton@kernel.org>
    Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/ceph/export.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/fs/ceph/export.c b/fs/ceph/export.c
    index 3c59ad180ef0b..4cfe1154d4c72 100644
    --- a/fs/ceph/export.c
    +++ b/fs/ceph/export.c
    @@ -151,6 +151,11 @@ static struct dentry *__get_parent(struct super_block *sb,

    req->r_num_caps = 1;
    err = ceph_mdsc_do_request(mdsc, NULL, req);
    + if (err) {
    + ceph_mdsc_put_request(req);
    + return ERR_PTR(err);
    + }
    +
    inode = req->r_target_inode;
    if (inode)
    ihold(inode);
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-05-01 15:32    [W:4.024 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site