lkml.org 
[lkml]   [2020]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 00/10] change the implementation of the PageHighMem()
    On Fri, May 01, 2020 at 07:52:35PM +0900, Joonsoo Kim wrote:
    > > - New code will pop up which gets it wrong and nobody will notice for
    > > a long time.
    >
    > Hmm... I think that it's not that hard to decide correct macro. If we rename
    > PageHighMem() with PageDirectMapped(), they, PageDirectMapped() and
    > PageHighMemZone(), are self-explanation macro. There would be no
    > confusion to use.

    What confuses me is why we even need PageHighMemZone - mostly code
    should not care about particular zones. Maybe just open coding
    PageHighMemZone makes more sense - it is a little more cumersome, but
    at least it makes it explicit what we check for. I already sent you
    an incremental diff for one obvious place, but maybe we need to look
    through the remaining ones if we can kill them or open code them in an
    obvious way.

    \
     
     \ /
      Last update: 2020-05-01 12:57    [W:7.731 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site