Messages in this thread | | | Date | Fri, 01 May 2020 15:28:37 -0700 (PDT) | Subject | Re: [PATCH v2] net: Make PTP-specific drivers depend on PTP_1588_CLOCK | From | David Miller <> |
| |
From: Clay McClure <clay@daemons.net> Date: Wed, 29 Apr 2020 00:59:00 -0700
> Commit d1cbfd771ce8 ("ptp_clock: Allow for it to be optional") changed > all PTP-capable Ethernet drivers from `select PTP_1588_CLOCK` to `imply > PTP_1588_CLOCK`, "in order to break the hard dependency between the PTP > clock subsystem and ethernet drivers capable of being clock providers." > As a result it is possible to build PTP-capable Ethernet drivers without > the PTP subsystem by deselecting PTP_1588_CLOCK. Drivers are required to > handle the missing dependency gracefully. ... > Note how these symbols all reference PTP or timestamping in their name; > this is a clue that they depend on PTP_1588_CLOCK. > > Change them from `imply PTP_1588_CLOCK` [2] to `depends on PTP_1588_CLOCK`. > I'm not using `select PTP_1588_CLOCK` here because PTP_1588_CLOCK has > its own dependencies, which `select` would not transitively apply. > > Additionally, remove the `select NET_PTP_CLASSIFY` from CPTS_TI_MOD; > PTP_1588_CLOCK already selects that. ...
Applied, thanks.
| |