Messages in this thread | | | Date | Thu, 09 Apr 2020 08:53:47 +0200 | Subject | Re: [PATCH] signal: check sig before setting info in kill_pid_usb_asyncio | From | Christian Brauner <> |
| |
On April 9, 2020 5:26:08 AM GMT+02:00, Zhiqiang Liu <liuzhiqiang26@huawei.com> wrote: >Friendly ping... > >On 2020/3/30 16:44, Christian Brauner wrote: >> On Mon, Mar 30, 2020 at 10:18:33AM +0800, Zhiqiang Liu wrote: >>> >>> In kill_pid_usb_asyncio, if signal is not valid, we do not need to >>> set info struct. >>> >>> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com> >> >> I'd have done: >> >> if (!valid_signal(sig)) >> return -EINVAL; >> >> instead of setting ret to EINVAL above but that's mostly a matter of >style. >> >> Picking this up unless someone sees a problem with it. >> >> Thank you! >> Acked-by: Christian Brauner <christian.brauner@ubuntu.com> >> >> . >>
The patches are queued for after rc1. So around next week. They came too late to make it into the merge window.
Christian
| |