lkml.org 
[lkml]   [2020]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3 4/4] usb: host: Add ability to build new Broadcom STB USB drivers
    On Thu, Apr 9, 2020 at 8:30 AM Andy Shevchenko
    <andy.shevchenko@gmail.com> wrote:
    >
    > On Thu, Apr 09, 2020 at 07:49:52AM -0400, Alan Cooper wrote:
    > > On Thu, Apr 9, 2020 at 5:08 AM Andy Shevchenko
    > > <andy.shevchenko@gmail.com> wrote:
    > > >
    > > > On Thu, Apr 9, 2020 at 12:52 AM Al Cooper <alcooperx@gmail.com> wrote:
    > > > >
    > > > > Add the build system changes needed to get the Broadcom STB XHCI,
    > > > > EHCI and OHCI functionality working. The OHCI support does not
    > > > > require anything unique to Broadcom so the standard ohci-platform
    > > > > driver is being used. The link order for XHCI was changed in the
    > > > > Makefile because of the way STB XHCI, EHCI and OHCI controllers
    > > > > share a port which requires that the XHCI driver be initialized
    > > > > first. Also update MAINTAINERS.
    > > >
    > > > > --- a/MAINTAINERS
    > > > > +++ b/MAINTAINERS
    > > > > @@ -3477,6 +3477,14 @@ S: Supported
    > > > > F: drivers/i2c/busses/i2c-brcmstb.c
    > > > > F: Documentation/devicetree/bindings/i2c/brcm,brcmstb-i2c.yaml
    > > > >
    > > > > +BROADCOM BRCMSTB USB EHCI DRIVER
    > > > > +M: Al Cooper <alcooperx@gmail.com>
    > > > > +L: linux-usb@vger.kernel.org
    > > > > +L: bcm-kernel-feedback-list@broadcom.com
    > > > > +S: Maintained
    > > > > +F: drivers/usb/host/ehci-brcm.*
    > > > > +F: Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
    > > >
    > > > This has ordering issues.
    > > > Run parse-maintainer.pl to fix. (Note, it creates by default a new
    > > > file, you might need to run diff manually to see the difference).
    > >
    > > I'm not sure what you mean.
    > > I ran "./scripts/parse-maintainers.pl" and did "diff MAINTAINERS
    > > MAINTAINERS.new" and there are no differences in or around my entry.
    >
    > Perhaps --order should be added.

    So you're asking me to swap the following lines?

    F: drivers/usb/host/ehci-brcm.*
    F: Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml

    Al

    >
    > --
    > With Best Regards,
    > Andy Shevchenko
    >
    >

    \
     
     \ /
      Last update: 2020-04-09 20:16    [W:2.771 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site