lkml.org 
[lkml]   [2020]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] nfp: Fix memory leak in nfp_resource_acquire()
From
From: Keita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp>
Date: Thu, 9 Apr 2020 15:02:07 +0000

> This patch fixes a memory leak in nfp_resource_acquire(). res->mutex is
> alllocated in nfp_resource_try_acquire(). However, when
> msleep_interruptible() or time_is_before_eq_jiffies() fails, it falls
> into err_fails path where res is freed, but res->mutex is not.
>
> Fix this by changing call to free to nfp_resource_release().
>
> Signed-off-by: Keita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp>

Did you test compile this?

drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.c: In function ‘nfp_resource_acquire’:
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.c:203:2: error: implicit declaration of function ‘nfp_resource_relase’; did you mean ‘nfp_resource_release’? [-Werror=implicit-function-declaration]
nfp_resource_relase(res);
^~~~~~~~~~~~~~~~~~~
nfp_resource_release

And this makes me feel like the test was not runtime tested either.
\
 
 \ /
  Last update: 2020-04-09 19:18    [W:0.089 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site