lkml.org 
[lkml]   [2020]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] Input: edt-ft5x06 - fix crash on EDT EP0110M09
On 09/04/20, Marco Felsch wrote:
> Hi Oliver,
>
> thanks for your patch.
>
> On 20-04-09 11:27, Oliver Graute wrote:
> > From: Oliver Graute <oliver.graute@kococonnector.com>
>
> ...
>
> > drivers/input/touchscreen/edt-ft5x06.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> > index 06aa8ba0b6d7..6fbc87d041a1 100644
> > --- a/drivers/input/touchscreen/edt-ft5x06.c
> > +++ b/drivers/input/touchscreen/edt-ft5x06.c
> > @@ -819,10 +819,6 @@ static int edt_ft5x06_ts_identify(struct i2c_client *client,
> > * to have garbage in there
> > */
> > memset(rdbuf, 0, sizeof(rdbuf));
> > - error = edt_ft5x06_ts_readwrite(client, 1, "\xBB",
> > - EDT_NAME_LEN - 1, rdbuf);
> > - if (error)
> > - return error;
>
>
> I don't see how this call can corrupt the stack..

I admit that this is strange. The patch fixed my problems so I posted
it. Still interested in the root-cause.

Best regards,

Oliver

\
 
 \ /
  Last update: 2020-04-09 14:02    [W:0.140 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site