Messages in this thread | | | Date | Thu, 9 Apr 2020 13:36:33 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH v10 2/2] drm/bridge: Add NWL MIPI DSI host controller support |
| |
Hi Guido.
> > > + > > > +/* i.MX8 NWL quirks */ > > > +/* i.MX8MQ errata E11418 */ > > > +#define E11418_HS_MODE_QUIRK BIT(0) > > > + > > > +#define NWL_DSI_MIPI_FIFO_TIMEOUT msecs_to_jiffies(500) > > Should the defines be moved to the header file? > > I've used this rules: register layout (that is chip properties) > go to the header file while defines specific to this very driver > go into the .c file. Hope that makes sense.
Makes good sense, thanks for the explanation.
Sam
| |