lkml.org 
[lkml]   [2020]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 08/46] media: imx: imx7_mipi_csis: Power off the source when stopping streaming
    Date
    From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

    [ Upstream commit 770cbf89f90b0663499dbb3f03aa81b3322757ec ]

    The .s_stream() implementation incorrectly powers on the source when
    stopping the stream. Power it off instead.

    Fixes: 7807063b862b ("media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7")
    Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/media/imx/imx7-mipi-csis.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c
    index e50b1f88e25b5..6f628195c4daa 100644
    --- a/drivers/staging/media/imx/imx7-mipi-csis.c
    +++ b/drivers/staging/media/imx/imx7-mipi-csis.c
    @@ -579,7 +579,7 @@ static int mipi_csis_s_stream(struct v4l2_subdev *mipi_sd, int enable)
    state->flags |= ST_STREAMING;
    } else {
    v4l2_subdev_call(state->src_sd, video, s_stream, 0);
    - ret = v4l2_subdev_call(state->src_sd, core, s_power, 1);
    + ret = v4l2_subdev_call(state->src_sd, core, s_power, 0);
    mipi_csis_stop_stream(state);
    state->flags &= ~ST_STREAMING;
    if (state->debug)
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-04-10 05:57    [W:4.109 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site