lkml.org 
[lkml]   [2020]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC 2/6] net/mlx5e: fix VXLAN dependency
    Date
    The 'imply' statement does not prevent MLX5 to be built-in and fail
    when VXLAN=m:

    aarch64-linux-ld: drivers/net/ethernet/mellanox/mlx5/core/main.o: in function `mlx5_init_once':
    main.c:(.text+0x7cc): undefined reference to `mlx5_vxlan_create'
    main.c:(.text+0x958): undefined reference to `mlx5_vxlan_destroy'

    Use a normal dependency instead.

    Fixes: c5791ab0abec ("net/mlx5e: vxlan.c depends on CONFIG_VXLAN")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
    index 312e0a1ad43d..849b0be0ca9a 100644
    --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
    @@ -8,7 +8,7 @@ config MLX5_CORE
    depends on PCI
    select NET_DEVLINK
    imply PTP_1588_CLOCK
    - imply VXLAN
    + depends on VXLAN || !VXLAN
    imply MLXFW
    imply PCI_HYPERV_INTERFACE
    default n
    --
    2.26.0
    \
     
     \ /
      Last update: 2020-04-08 22:29    [W:4.564 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site