lkml.org 
[lkml]   [2020]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ASoC: rt5682: fix building without I2C
From
Date


On 4/8/20 1:55 PM, Arnd Bergmann wrote:
> When I2C is disabled, building rt5682 produces a compile-time error:
>
> sound/soc/codecs/rt5682.c:3716:1: warning: data definition has no type or storage class
> 3716 | module_i2c_driver(rt5682_i2c_driver);
> | ^~~~~~~~~~~~~~~~~
> sound/soc/codecs/rt5682.c:3716:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
> sound/soc/codecs/rt5682.c:3716:1: warning: parameter names (without types) in function declaration
> sound/soc/codecs/rt5682.c:3706:26: error: 'rt5682_i2c_driver' defined but not used [-Werror=unused-variable]
> 3706 | static struct i2c_driver rt5682_i2c_driver = {
> | ^~~~~~~~~~~~~~~~~
>
> Move the i2c specific entry points into an #ifdef section so
> it can actually be built standalone.
>
> Fixes: 5549ea647997 ("ASoC: rt5682: fix unmet dependencies")

it's already fixed by [PATCH -next] ASoC: rt5682: Fix build error
without CONFIG_I2C



\
 
 \ /
  Last update: 2020-04-08 21:14    [W:0.114 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site