Messages in this thread | | | Date | Wed, 8 Apr 2020 11:04:35 +0200 | From | Pali Rohár <> | Subject | Re: [PATCH 1/4] exfat: Simplify exfat_utf8_d_hash() for code points above U+FFFF |
| |
On Wednesday 08 April 2020 03:59:06 Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp wrote: > > So partial_name_hash() like I used it in this patch series is enough? > > I think partial_name_hash() is enough for 8/16/21bit characters.
Great!
Al, could you please take this patch series?
> Another point about the discrimination of 21bit characters: > I think that checking in exfat_toupper () can be more simplified. > > ex: return a < PLANE_SIZE && sbi->vol_utbl[a] ? sbi->vol_utbl[a] : a;
I was thinking about it, but it needs more refactoring. Currently exfat_toupper() is used on other places for UTF-16 (u16 array) and therefore it cannot be extended to take more then 16 bit value.
But I agree that this is another step which can be improved.
| |