Messages in this thread | | | Date | Wed, 8 Apr 2020 09:33:58 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] staging: mt7621-pinctrl: Use correct pointer type argument for sizeof |
| |
On Wed, Apr 08, 2020 at 12:41:12PM +0530, R Veera Kumar wrote: > Use correct pointer type argument for sizeof. > Found using coccinelle. > > Signed-off-by: R Veera Kumar <vkor@vkten.in> > --- > drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c > index d0f06790d38f..62babad5ee0b 100644 > --- a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c > +++ b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c > @@ -220,7 +220,7 @@ static int rt2880_pinmux_index(struct rt2880_priv *p) > /* allocate our function and group mapping index buffers */ > f = p->func = devm_kcalloc(p->dev, > p->func_count, > - sizeof(struct rt2880_pmx_func), > + sizeof(rt2880_pmx_func),
Did you build this change?
Always do so.
Also, nothing is really wrong with the existing code, remember, checkpatch is a hint, telling you that maybe something is odd with this line. It is not always correct.
thanks,
greg k-h
| |