lkml.org 
[lkml]   [2020]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC v2 02/24] scsi: allocate separate queue for reserved commands
On Tue, Apr 07, 2020 at 04:00:10PM +0200, Hannes Reinecke wrote:
> My concern is this:
>
> struct scsi_device *scsi_get_host_dev(struct Scsi_Host *shost)
> {
> [ .. ]
> starget = scsi_alloc_target(&shost->shost_gendev, 0, shost->this_id);
> [ .. ]
>
> and we have typically:
>
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: .this_id = -1,
>
> It's _very_ uncommon to have a negative number as the SCSI target device; in
> fact, it _is_ an unsigned int already.
>
> But alright, I'll give it a go; let's see what I'll end up with.

But this shouldn't be exposed anywhere. And I prefer that over having
magic requests/scsi_cmnd that do not have a valid ->device pointer.

\
 
 \ /
  Last update: 2020-04-07 18:31    [W:0.101 / U:8.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site