lkml.org 
[lkml]   [2020]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [v2] iio: core: move 'indio_dev->info' null check first
From
Date
>     Doesn't fix anything.

You would like to change something for a specific reason.
Thus please omit this sentence.


> Just moves this to be the first check, as it's very …

Wording alternative:
Move a null pointer check to the beginning of this function implementation.


> This is a minor optimization, since '__iio_device_register()' will waste
> fewer validation cycles in case 'indio_dev->info' is NULL.

How do you think about to use the text “iio: core: Improve input parameter validation
in __iio_device_register()” as a commit subject?

Regards,
Markus

\
 
 \ /
  Last update: 2020-04-07 14:13    [W:0.034 / U:4.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site