[lkml]   [2020]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] iio: core: move 'indio_dev->info' null check first
On Tue, 2020-04-07 at 10:20 +0200, Markus Elfring wrote:
> [External]
> > Doesn't fix anything.
> Would the change description be nicer without this sentence?

That part is slightly debate-able.
I've had my fair-share of comments [during reviews], where others were
asking/saying "is this fixing anything? please state if this is fixing

So, over time I got the habit of mentioning 'Doesn't fix anything.' if the patch
doesn't fix anything.

So, I'd leave it as-is [if that's possible].

> > Just moves this …
> I suggest to choose an imperative wording.

I admit, I didn't read that document too much in-depth.
And I probably won't, because I am lazy.

Personally, what I try to do, is guess the maintainer's/community's preferences
over time via interactions.
Things differ slightly from community to community.
Of course, there is some common ground across all communities, and I try to
apply that first.
Then, depending on the flexibility/past-comments from other sent-patches I try
to apply those on top [unless I forget; which I kinda do].

> Regards,
> Markus
 \ /
  Last update: 2020-04-07 10:47    [W:0.084 / U:2.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site