Messages in this thread | | | Date | Tue, 7 Apr 2020 16:38:48 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH v3 2/2] arm64: dts: qcom: sm8150: Add USB and PHY device nodes |
| |
On Tue 07 Apr 15:24 PDT 2020, Wesley Cheng wrote:
> From: Jack Pham <jackp@codeaurora.org> > > Add device nodes for the USB3 controller, QMP SS PHY and > SNPS HS PHY. >
Thanks for the respin Wesley, and thanks for testing Vinod. Just spotted one little details below.
> Signed-off-by: Jack Pham <jackp@codeaurora.org> > Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Tested-by: Vinod Koul <vinod.koul@linaro.org> > ---
Please make a habit of documenting what changed since the previous version here, below the ---.
> arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 21 ++++++++ > arch/arm64/boot/dts/qcom/sm8150.dtsi | 92 +++++++++++++++++++++++++++++++++ > 2 files changed, 113 insertions(+) [..] > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi [..] > + usb_1_hsphy: phy@88e2000 { > + compatible = "qcom,usb-snps-hs-7nm-phy", > + "qcom,sm8150-usb-hs-phy"; [..] > + usb_1: usb@a6f8800 { > + compatible = "qcom,sdm845-dwc3", "qcom,dwc3";
The first cell here should be qcom,sm8150-dwc3. The Linux driver will "fall through" and match on the less specific "qcom,dwc3", but if we in the future realize that we have sm8150 specific behavior/quirks we can make the driver match on the more specific one to implement this.
And similarly the order of the compatibles in &usb_1_hsphy should be reversed as well.
Regards, Bjorn
| |