lkml.org 
[lkml]   [2020]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 5/5] usb: chipidea: allow disabling glue drivers if EMBEDDED
On Tue, Apr 07, 2020 at 03:12:36AM +0000, Peter Chen wrote:
> On 20-04-04 02:00:06, Michał Mirosław wrote:
> > Allow to cut down on driver size for embedded config.
> >
> > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> > ---
> > drivers/usb/chipidea/Kconfig | 37 ++++++++++++++++++++++++-----------
> > drivers/usb/chipidea/Makefile | 12 +++++-------
> > 2 files changed, 31 insertions(+), 18 deletions(-)
> >
> > diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig
> > index d53db520e209..8bafcfc6080d 100644
> > --- a/drivers/usb/chipidea/Kconfig
> > +++ b/drivers/usb/chipidea/Kconfig
> > @@ -18,17 +18,6 @@ config USB_CHIPIDEA
> >
> > if USB_CHIPIDEA
> >
> > -config USB_CHIPIDEA_OF
> > - tristate
> > - depends on OF
> > - default USB_CHIPIDEA
> > -
> > -config USB_CHIPIDEA_PCI
> > - tristate
> > - depends on USB_PCI
> > - depends on NOP_USB_XCEIV
> > - default USB_CHIPIDEA
> > -
> > config USB_CHIPIDEA_UDC
> > bool "ChipIdea device controller"
> > depends on USB_GADGET
> > @@ -43,4 +32,30 @@ config USB_CHIPIDEA_HOST
> > help
> > Say Y here to enable host controller functionality of the
> > ChipIdea driver.
> > +
> > +config USB_CHIPIDEA_PCI
> > + tristate "Enable PCI glue driver" if EMBEDDED
[...]
> Why depends on EMBEDDED for this driver? Not everyone needs this
> configuration.

This does not make the driver depend on EMBEDDED, only the prompts are.
By default (without CONFIG_EMBEDDED) you will have all glue layers built
if you enable the driver. I can remove the 'if EMBEDDED', but
I suppose those options are only relevant for people building for
resource-constrained systems, so would have EMBEDDED enabled anyway.

Best Regards,
Michał Mirosław

\
 
 \ /
  Last update: 2020-04-07 22:01    [W:0.062 / U:10.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site