lkml.org 
[lkml]   [2020]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] tty: serial: fsl_lpuart: make coverity happy
On Fri, Apr 3, 2020 at 2:50 PM Michael Walle <michael@walle.cc> wrote:
>
> Coverity reports the following:
>
> var_compare_op: Comparing chan to null implies that chan might be null.
>
> 1234 if (chan)
> 1235 dmaengine_terminate_all(chan);
> 1236
>
> Dereference after null check (FORWARD_NULL)
> var_deref_op: Dereferencing null pointer chan.
>
> 1237 dma_unmap_sg(chan->device->dev, &sport->rx_sgl, 1, DMA_FROM_DEVICE);
>
> Technically, this is correct. But lpuart_dma_rx_free() is guarded by
> lpuart_dma_rx_use which is only true if there is a dma channel, see
> lpuart_rx_dma_startup(). In any way, this looks bogus. So remove
> the superfluous "if (chan)" check and make coverity happy.
>
> Fixes: a092ab25fdaa ("tty: serial: fsl_lpuart: fix DMA mapping")
> Signed-off-by: Michael Walle <michael@walle.cc>
> Reported-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

\
 
 \ /
  Last update: 2020-04-06 16:51    [W:0.088 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site