Messages in this thread | | | From | Manish Narani <> | Subject | RE: [PATCH v2 3/4] mmc: sdhci-of-arasan: Modify clock operations handling | Date | Mon, 6 Apr 2020 13:55:04 +0000 |
| |
Hi Adrian,
Thanks for the review.
> -----Original Message----- > From: Adrian Hunter <adrian.hunter@intel.com> > Sent: Thursday, April 2, 2020 3:40 PM > To: Manish Narani <MNARANI@xilinx.com>; ulf.hansson@linaro.org; > robh+dt@kernel.org; mark.rutland@arm.com; Michal Simek > <michals@xilinx.com> > Cc: linux-mmc@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; git > <git@xilinx.com> > Subject: Re: [PATCH v2 3/4] mmc: sdhci-of-arasan: Modify clock operations > handling > > On 30/03/20 8:41 am, Manish Narani wrote: > > The SDHCI clock operations are platform specific. So it better to define > > them separately for particular platform. This will prevent multiple > > if..else conditions and will make it easy for user to add their own > > clock operations handlers. > > > > Signed-off-by: Manish Narani <manish.narani@xilinx.com> > > --- > > drivers/mmc/host/sdhci-of-arasan.c | 208 +++++++++++++++++------------ > > 1 file changed, 119 insertions(+), 89 deletions(-) > > Would you mind splitting this into a patch that moves the existing > structures first, and then a second patch to make the changes.
Noted. Will do that in next patch series.
> > Also, I notice there is 'struct sdhci_arasan_data' but also > 'struct sdhci_arasan_of_data sdhci_arasan_data'. This is confusing, so > perhaps a preparatory patch that renames the latter from sdhci_arasan_data > to somethine else e.g. sdhci_arasan_generic_data
Okay. I will create a separate patch for renaming the sdhci_arasan_data.
Thanks, Manish
| |