Messages in this thread | | | Date | Mon, 6 Apr 2020 15:03:51 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 3/6] binfmt_elf: remove the set_fs(KERNEL_DS) in elf_core_dump |
| |
On Mon, Apr 06, 2020 at 02:02:38PM +0100, Al Viro wrote: > On Mon, Apr 06, 2020 at 02:03:09PM +0200, Christoph Hellwig wrote: > > There is no logic in elf_core_dump itself that uses uaccess routines > > on kernel pointers, the file writes are nicely encapsulated in dump_emit > > which does its own set_fs. > > ... assuming you've checked the asm/elf.h to see that nobody is playing > silly buggers in these forests of macros and the stuff called from those. > Which is a feat that ought to be mentioned in commit message...
None of the calls should go into asm/elf.h headers, but some go to various out of line arch callouts. And I did look through those - spufs was the only funky one.
| |