Messages in this thread | | | From | Qiujun Huang <> | Date | Sun, 5 Apr 2020 18:21:49 +0800 | Subject | Re: [PATCH] powerpc/powernv: add NULL check after kzalloc in opal_add_one_export |
| |
On Sun, Apr 5, 2020 at 6:13 PM Christophe Leroy <christophe.leroy@c-s.fr> wrote: > > > > Le 05/04/2020 à 09:51, Qiujun Huang a écrit : > > Here needs a NULL check. > > > > Issue found by coccinelle. > > > > Signed-off-by: Qiujun Huang <hqjagain@gmail.com> > > --- > > arch/powerpc/platforms/powernv/opal.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c > > index 2b3dfd0b6cdd..09443ae3a86e 100644 > > --- a/arch/powerpc/platforms/powernv/opal.c > > +++ b/arch/powerpc/platforms/powernv/opal.c > > @@ -811,6 +811,11 @@ static int opal_add_one_export(struct kobject *parent, const char *export_name, > > goto out; > > > > attr = kzalloc(sizeof(*attr), GFP_KERNEL); > > + if (!attr) { > > + rc = -ENOMEM; > > + goto out; > > You don't need to go to out:, there is nothing to do. You should do: > > if (!attr) > return -ENOMEM;
Yeah, I get that. Thanks.
> > > + } > > + > > name = kstrdup(export_name, GFP_KERNEL); > > if (!name) { > > rc = -ENOMEM; > > > > Christophe
| |