Messages in this thread | | | Subject | Re: [PATCH v2 net] skbuff.h: Improve the checksum related comments | From | Randy Dunlap <> | Date | Sun, 5 Apr 2020 18:42:33 -0700 |
| |
On 4/5/20 6:26 PM, Dexuan Cui wrote: > @@ -211,9 +211,9 @@ > * is implied by the SKB_GSO_* flags in gso_type. Most obviously, if the > * gso_type is SKB_GSO_TCPV4 or SKB_GSO_TCPV6, TCP checksum offload as > * part of the GSO operation is implied. If a checksum is being offloaded > - * with GSO then ip_summed is CHECKSUM_PARTIAL, csum_start and csum_offset > - * are set to refer to the outermost checksum being offload (two offloaded > - * checksums are possible with UDP encapsulation). > + * with GSO then ip_summed is CHECKSUM_PARTIAL, and both csum_start and > + * csum_offset are set to refer to the outermost checksum being offload (two
being offloaded
> + * offloaded checksums are possible with UDP encapsulation). > */ > > /* Don't change this without changing skb_csum_unnecessary! */
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks. -- ~Randy
| |