lkml.org 
[lkml]   [2020]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 17/17] net: systemport: suppress warnings on failed Rx SKB allocations
    Date
    From: Doug Berger <opendmb@gmail.com>

    [ Upstream commit 3554e54a46125030c534820c297ed7f6c3907e24 ]

    The driver is designed to drop Rx packets and reclaim the buffers
    when an allocation fails, and the network interface needs to safely
    handle this packet loss. Therefore, an allocation failure of Rx
    SKBs is relatively benign.

    However, the output of the warning message occurs with a high
    scheduling priority that can cause excessive jitter/latency for
    other high priority processing.

    This commit suppresses the warning messages to prevent scheduling
    problems while retaining the failure count in the statistics of
    the network interface.

    Signed-off-by: Doug Berger <opendmb@gmail.com>
    Acked-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/bcmsysport.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
    index 6519dd33c7ca2..5d67dbdd943dc 100644
    --- a/drivers/net/ethernet/broadcom/bcmsysport.c
    +++ b/drivers/net/ethernet/broadcom/bcmsysport.c
    @@ -504,7 +504,8 @@ static struct sk_buff *bcm_sysport_rx_refill(struct bcm_sysport_priv *priv,
    dma_addr_t mapping;

    /* Allocate a new SKB for a new packet */
    - skb = netdev_alloc_skb(priv->netdev, RX_BUF_LENGTH);
    + skb = __netdev_alloc_skb(priv->netdev, RX_BUF_LENGTH,
    + GFP_ATOMIC | __GFP_NOWARN);
    if (!skb) {
    priv->mib.alloc_rx_buff_failed++;
    netif_err(priv, rx_err, ndev, "SKB alloc failed\n");
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-04-30 15:57    [W:2.924 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site