Messages in this thread Patch in this message | | | Subject | RE: [PATCH v2 2/5] scsi: ufs: add "index" in parameter list of ufshcd_query_flag() | From | Stanley Chu <> | Date | Thu, 30 Apr 2020 16:35:25 +0800 |
| |
Hi Avri,
On Thu, 2020-04-30 at 07:56 +0000, Avri Altman wrote: > > > > For preparation of LU Dedicated buffer mode support on WriteBooster > > feature, "index" parameter shall be added and allowed to be specified > > by callers. > > > > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> > > Reviewed-by: Bean Huo <beanhuo@micron.com> > > --- > > drivers/scsi/ufs/ufs-sysfs.c | 2 +- > > drivers/scsi/ufs/ufshcd.c | 28 +++++++++++++++------------- > > drivers/scsi/ufs/ufshcd.h | 2 +- > > 3 files changed, 17 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/scsi/ufs/ufs-sysfs.c b/drivers/scsi/ufs/ufs-sysfs.c > > index 93484408bc40..b86b6a40d7e6 100644 > > --- a/drivers/scsi/ufs/ufs-sysfs.c > > +++ b/drivers/scsi/ufs/ufs-sysfs.c > > @@ -631,7 +631,7 @@ static ssize_t _name##_show(struct device *dev, > > \ > > struct ufs_hba *hba = dev_get_drvdata(dev); \ > > pm_runtime_get_sync(hba->dev); \ > > ret = ufshcd_query_flag(hba, UPIU_QUERY_OPCODE_READ_FLAG, \ > > - QUERY_FLAG_IDN##_uname, &flag); \ > > + QUERY_FLAG_IDN##_uname, 0, &flag); \ > The sysfs entries for flags needs to get an _index argument now
Sure, I will fix this in next version.
Thanks, Stanley Chu
| |