lkml.org 
[lkml]   [2020]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC PATCH V2 2/9] md: remove __clear_page_buffers and use attach/clear_page_private
    Date
    After introduce attach/clear_page_private in pagemap.h, we can remove
    the duplicat code and call the new functions.

    Cc: Song Liu <song@kernel.org>
    Cc: linux-raid@vger.kernel.org
    Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
    ---
    RFC -> RFC V2
    1. change the name of new functions to attach/clear_page_private.

    drivers/md/md-bitmap.c | 12 ++----------
    1 file changed, 2 insertions(+), 10 deletions(-)

    diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
    index b952bd45bd6a..033d12063600 100644
    --- a/drivers/md/md-bitmap.c
    +++ b/drivers/md/md-bitmap.c
    @@ -324,14 +324,6 @@ static void end_bitmap_write(struct buffer_head *bh, int uptodate)
    wake_up(&bitmap->write_wait);
    }

    -/* copied from buffer.c */
    -static void
    -__clear_page_buffers(struct page *page)
    -{
    - ClearPagePrivate(page);
    - set_page_private(page, 0);
    - put_page(page);
    -}
    static void free_buffers(struct page *page)
    {
    struct buffer_head *bh;
    @@ -345,7 +337,7 @@ static void free_buffers(struct page *page)
    free_buffer_head(bh);
    bh = next;
    }
    - __clear_page_buffers(page);
    + clear_page_private(page);
    put_page(page);
    }

    @@ -374,7 +366,7 @@ static int read_page(struct file *file, unsigned long index,
    ret = -ENOMEM;
    goto out;
    }
    - attach_page_buffers(page, bh);
    + attach_page_private(page, bh);
    blk_cur = index << (PAGE_SHIFT - inode->i_blkbits);
    while (bh) {
    block = blk_cur;
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-04-30 23:52    [W:4.060 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site