| Subject | Re: [PATCH v9 09/18] arm64: kexec: call kexec_image_info only once | From | James Morse <> | Date | Wed, 29 Apr 2020 18:01:33 +0100 |
| |
Hi Pavel,
On 26/03/2020 03:24, Pavel Tatashin wrote: > Currently, kexec_image_info() is called during load time, and > right before kernel is being kexec'ed. There is no need to do both.
I think the original logic was if debugging, you'd see the load-time value in dmesg, and the kexec-time values when the machine panic()d and you hadn't made a note of the previous set. But I'm not sure why you'd have these debug messages enabled unless you were debugging kexec.
> So, call it only once when segments are loaded and the physical > location of page with copy of arm64_relocate_new_kernel is known.
Sure, keep the earlier version that is more likely to be seen.
Acked-by: James Morse <james.morse@arm.com>
Thanks,
James
|