Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 29 Apr 2020 14:22:08 +0200 | Subject | Re: [PATCH] HID: mcp2221: add gpiolib dependency |
| |
On Tue, Apr 28, 2020 at 11:30 PM Arnd Bergmann <arnd@arndb.de> wrote:
> Without gpiolib, this driver fails to link: > > arm-linux-gnueabi-ld: drivers/hid/hid-mcp2221.o: in function `mcp2221_probe': > hid-mcp2221.c:(.text+0x1b0): undefined reference to `devm_gpiochip_add_data' > arm-linux-gnueabi-ld: drivers/hid/hid-mcp2221.o: in function `mcp_gpio_get': > hid-mcp2221.c:(.text+0x30c): undefined reference to `gpiochip_get_data' > > Fixes: 328de1c519c5 ("HID: mcp2221: add GPIO functionality support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> config HID_MCP2221 > tristate "Microchip MCP2221 HID USB-to-I2C/SMbus host support" > depends on USB_HID && I2C > + depends on GPIOLIB
These days we can even do select GPIOLIB, but I suppose that would make the driver selectable on platforms with no native GPIO support at all (like UM) so I suppose this is better.
Yours, Linus Walleij
| |