Messages in this thread | | | Date | Wed, 29 Apr 2020 13:17:42 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v3 3/4] gpio: thunderx: Utilize for_each_set_clump macro |
| |
On Wed, Apr 29, 2020 at 04:37:41AM +0530, Syed Nayyar Waris wrote: > This patch reimplements the thunderx_gpio_set_multiple function in > drivers/gpio/gpio-thunderx.c to use the new for_each_set_clump macro. > Instead of looping for each bank in thunderx_gpio_set_multiple > function, now we can skip bank which is not set and save cycles.
> + const unsigned long bank_size = 64;
Shouldn't be rather definition?
-- With Best Regards, Andy Shevchenko
| |