Messages in this thread | | | Subject | Re: [PATCH -next v2] hinic: Use ARRAY_SIZE for nic_vf_cmd_msg_handler | From | Samuel Zou <> | Date | Thu, 30 Apr 2020 09:38:20 +0800 |
| |
On 2020/4/30 2:43, David Miller wrote: > From: Zou Wei <zou_wei@huawei.com> > Date: Wed, 29 Apr 2020 12:17:40 +0800 > >> fix coccinelle warning, use ARRAY_SIZE >> >> drivers/net/ethernet/huawei/hinic/hinic_sriov.c:713:43-44: WARNING: Use ARRAY_SIZE >> >> ---------- > > Please don't put this "-------" here. > >> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c >> index b24788e..af70cca 100644 >> --- a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c >> +++ b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c >> @@ -704,17 +704,15 @@ int nic_pf_mbox_handler(void *hwdev, u16 vf_id, u8 cmd, void *buf_in, >> struct hinic_hwdev *dev = hwdev; >> struct hinic_func_to_io *nic_io; >> struct hinic_pfhwdev *pfhwdev; >> - u32 i, cmd_number; >> + u32 i; >> int err = 0; > > Please preserve the reverse christmas tree ordering of local variables. > > . > Thanks,I will modify and send v3 patch
| |