Messages in this thread | | | From | Arnd Bergmann <> | Date | Wed, 29 Apr 2020 22:13:18 +0200 | Subject | Re: [PATCH] [v2] ARM: oabi-compat: fix epoll_ctl build failure |
| |
On Wed, Apr 29, 2020 at 3:35 PM Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote: > On Wed, Apr 29, 2020 at 03:23:24PM +0200, Arnd Bergmann wrote: > > Two functions are not declared or defined when CONFIG_EPOLL is > > disabled: > > > > I know what Chris said, but do we really want to be polluting generic > kernel files with arch specific stuff like this?
The file already has a couple of architecture specific syscalls listed already, so it shouldn't be a big deal. If you prefer the first version of my patch, or have another suggestion, I don't mind sending a v3 that does it differently again.
Unfortunately, COND_SYSCALL() is a locally defined macro in that file, so we can't easily use it elsewhere without duplicating it like in kernel/time/posix-stubs.c.
As I mentioned in v1, it's also possible to just make this function compile without #ifdefs by having conditional stub definitions of the missing interfaces.
Arnd
| |