lkml.org 
[lkml]   [2020]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 03/10] efi/x86: Use pr_efi_err for error messages
On Wed, 29 Apr 2020 at 20:47, Joe Perches <joe@perches.com> wrote:
>
> On Wed, 2020-04-29 at 13:41 -0400, Arvind Sankar wrote:
> > Use pr_efi_err instead of bare efi_printk for error messages.
>
> Perhaps it'd be better to rename pr_efi_err to eri_err
> to it's clearer it's a typical efi_ logging function.
>
> $ git grep -w --name-only pr_efi_err | \
> xargs sed -i 's/\bpr_efi_err\b/efi_err/g'
>

Yeah, pr_efi_err() is probably not the best name

> Looking at code for efi_printk -> efi_char16_printk,
> it's somewhat difficult to see where the "output_string"
> function pointer is set. Any clue?
>

It is set by the firmware.

\
 
 \ /
  Last update: 2020-04-29 20:50    [W:0.077 / U:4.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site