lkml.org 
[lkml]   [2020]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 07/11] iio: light: cm32181: Change reg_init to use a bitmap of which registers to init
    Date
    This is a preparation patch for reading some ACPI tables which give
    init values for multiple registers.

    Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    ---
    Changes in v2:
    - Use unsigned long for init_regs_bitmap
    - Use for_each_set_bit()
    ---
    drivers/iio/light/cm32181.c | 14 ++++++--------
    1 file changed, 6 insertions(+), 8 deletions(-)

    diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
    index c23a5c3a86a3..bcea669d20cb 100644
    --- a/drivers/iio/light/cm32181.c
    +++ b/drivers/iio/light/cm32181.c
    @@ -26,7 +26,7 @@
    #define CM32181_REG_ADDR_ID 0x07

    /* Number of Configurable Registers */
    -#define CM32181_CONF_REG_NUM 0x01
    +#define CM32181_CONF_REG_NUM 4

    /* CMD register */
    #define CM32181_CMD_ALS_DISABLE BIT(0)
    @@ -53,10 +53,6 @@

    #define SMBUS_ALERT_RESPONSE_ADDRESS 0x0c

    -static const u8 cm32181_reg[CM32181_CONF_REG_NUM] = {
    - CM32181_REG_ADDR_CMD,
    -};
    -
    /* CM3218 Family */
    static const int cm3218_als_it_bits[] = { 0, 1, 2, 3 };
    static const int cm3218_als_it_values[] = { 100000, 200000, 400000, 800000 };
    @@ -71,6 +67,7 @@ struct cm32181_chip {
    struct i2c_client *client;
    struct mutex lock;
    u16 conf_regs[CM32181_CONF_REG_NUM];
    + unsigned long init_regs_bitmap;
    int calibscale;
    int num_als_it;
    const int *als_it_bits;
    @@ -115,12 +112,13 @@ static int cm32181_reg_init(struct cm32181_chip *cm32181)
    /* Default Values */
    cm32181->conf_regs[CM32181_REG_ADDR_CMD] =
    CM32181_CMD_ALS_IT_DEFAULT | CM32181_CMD_ALS_SM_DEFAULT;
    + cm32181->init_regs_bitmap = BIT(CM32181_REG_ADDR_CMD);
    cm32181->calibscale = CM32181_CALIBSCALE_DEFAULT;

    /* Initialize registers*/
    - for (i = 0; i < CM32181_CONF_REG_NUM; i++) {
    - ret = i2c_smbus_write_word_data(client, cm32181_reg[i],
    - cm32181->conf_regs[i]);
    + for_each_set_bit(i, &cm32181->init_regs_bitmap, CM32181_CONF_REG_NUM) {
    + ret = i2c_smbus_write_word_data(client, i,
    + cm32181->conf_regs[i]);
    if (ret < 0)
    return ret;
    }
    --
    2.26.0
    \
     
     \ /
      Last update: 2020-04-28 19:30    [W:4.384 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site