Messages in this thread | | | Date | Tue, 28 Apr 2020 15:40:10 +0200 | From | Greg KH <> | Subject | Re: [PATCH] Staging: mt7621-dma: mtk-hsdma.c: Fix Missing a blank line after declarations |
| |
On Tue, Apr 28, 2020 at 02:21:25PM +0100, John Oldman wrote: > I was not so happy about this one, even though I went and committed it. > > Without the blank line checkpatch reports: > > WARNING: Missing a blank line after declarations > #160: FILE: drivers/staging/mt7621-dma/mtk-hsdma.c:160: > + struct tasklet_struct task; > + volatile unsigned long chan_issued; > > So I dumly inserted a blank line to silence checkpatch.
As checkpatch is just a simple script, it is not always right, don't blindly follow it.
> In hindsight maybe a false positive, blank lines in a struct might not be > helpful.
It can be, but not here.
thanks,
greg k-h
| |