lkml.org 
[lkml]   [2020]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tty: hvc: Fix data abort due to race in hvc_open
From
Date
> Hence, serialize hvc_open and check if tty->private_data is NULL before
> proceeding ahead.

How do you think about to add the tag “Fixes” because of adjustments
for the data synchronisation?



> +++ b/drivers/tty/hvc/hvc_console.c

@@ -384,6 +394,8 @@ static int hvc_open(struct tty_struct *tty, struct file * filp)

> +out:
> + mutex_unlock(&hvc_open_mutex);
> return rc;
> }

I suggest to use the label “unlock” instead.

Regards,
Markus

\
 
 \ /
  Last update: 2020-04-28 14:49    [W:0.040 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site