lkml.org 
[lkml]   [2020]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 7/8] usb: mausb_host: MA-USB PAL events processing
On Sat, Apr 25, 2020 at 11:19:53AM +0200, vladimir.stankovic@displaylink.com wrote:
> +static int mausb_device_assign_address(struct mausb_device *dev,
> + struct mausb_usb_device_ctx *usb_dev_ctx)
> +{
> + int status =
> + mausb_setusbdevaddress_event_to_user(dev,
> + usb_dev_ctx->dev_handle,
> + RESPONSE_TIMEOUT);
> +
> + mausb_pr_info("dev_handle=%#x, status=%d", usb_dev_ctx->dev_handle,
> + status);

When drivers are working properly, they are totally silent. Please
remove this type of debugging code from the driver entirely, or change
it to be dev_dbg().

Otherwise this really looks like a very noisy driver.

greg k-h

\
 
 \ /
  Last update: 2020-04-28 13:09    [W:0.220 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site