| Date | Tue, 28 Apr 2020 13:08:36 +0200 | From | Greg KH <> | Subject | Re: [PATCH v5 7/8] usb: mausb_host: MA-USB PAL events processing |
| |
On Sat, Apr 25, 2020 at 11:19:53AM +0200, vladimir.stankovic@displaylink.com wrote: > +static int mausb_device_assign_address(struct mausb_device *dev, > + struct mausb_usb_device_ctx *usb_dev_ctx) > +{ > + int status = > + mausb_setusbdevaddress_event_to_user(dev, > + usb_dev_ctx->dev_handle, > + RESPONSE_TIMEOUT); > + > + mausb_pr_info("dev_handle=%#x, status=%d", usb_dev_ctx->dev_handle, > + status);
When drivers are working properly, they are totally silent. Please remove this type of debugging code from the driver entirely, or change it to be dev_dbg().
Otherwise this really looks like a very noisy driver.
greg k-h
|