Messages in this thread | | | Date | Tue, 28 Apr 2020 11:37:16 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 2/4] mfd: wm8994: Fix unbalanced calls to regulator_bulk_disable() |
| |
On Mon, 27 Apr 2020, Marek Szyprowski wrote:
> When runtime PM is enabled, regulators are being controlled by the > driver's suspend and resume callbacks. They are also unconditionally > enabled at driver's probe(), and disabled in remove() functions. Add > more calls to runtime PM framework to ensure that the device's runtime > PM state matches the regulators state: > 1. at the end of probe() function: set runtime PM state to active, so > there will be no spurious call to resume(); > 2. in remove(), ensure that resume() is called before disabling runtime PM > management and unconditionally disabling the regulators. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> > --- > drivers/mfd/wm8994-core.c | 3 +++ > 1 file changed, 3 insertions(+)
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |