Messages in this thread | | | Date | Tue, 28 Apr 2020 11:07:45 +0100 | From | Mark Rutland <> | Subject | Re: [PATCH] hw_breakpoint: Remove unused '__register_perf_hw_breakpoint' declaration |
| |
Hi Bhupesh,
On Tue, Apr 28, 2020 at 02:22:17PM +0530, Bhupesh Sharma wrote: > commit b326e9560a28 ("hw-breakpoints: Use overflow handler instead of > the event callback") removed '__register_perf_hw_breakpoint' function > usage and replaced it with 'register_perf_hw_breakpoint' function. > > Remove the left-over unused '__register_perf_hw_breakpoint' declaration > from 'hw_breakpoint.h' as well. > > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Will Deacon <will@kernel.org> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
This is generic code, so I'm a bit confused as to why you've sent it to us. I'd expect this to go via the perf core maintainers (cc'd).
FWIW, this looks sane to me, so:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> --- > include/linux/hw_breakpoint.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h > index 6058c3844a76..fe1302da8e0f 100644 > --- a/include/linux/hw_breakpoint.h > +++ b/include/linux/hw_breakpoint.h > @@ -72,7 +72,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr, > void *context); > > extern int register_perf_hw_breakpoint(struct perf_event *bp); > -extern int __register_perf_hw_breakpoint(struct perf_event *bp); > extern void unregister_hw_breakpoint(struct perf_event *bp); > extern void unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events); > > @@ -115,8 +114,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr, > void *context) { return NULL; } > static inline int > register_perf_hw_breakpoint(struct perf_event *bp) { return -ENOSYS; } > -static inline int > -__register_perf_hw_breakpoint(struct perf_event *bp) { return -ENOSYS; } > static inline void unregister_hw_breakpoint(struct perf_event *bp) { } > static inline void > unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events) { } > -- > 2.7.4 >
| |