lkml.org 
[lkml]   [2020]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] clk/meson: fixes memleak issue in init err branch
Date
In common init function, when run into err branch, we didn`t
use kfree to release kzmalloc area, this may bring in memleak

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/clk/meson/meson8b.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c
index 34a70c4b4899..0f07d5a4cd16 100644
--- a/drivers/clk/meson/meson8b.c
+++ b/drivers/clk/meson/meson8b.c
@@ -3687,6 +3687,7 @@ static void __init meson8b_clkc_init_common(struct device_node *np,
if (ret) {
pr_err("%s: Failed to register clkc reset controller: %d\n",
__func__, ret);
+ kfree(rstc);
return;
}

@@ -3710,8 +3711,10 @@ static void __init meson8b_clkc_init_common(struct device_node *np,
continue;

ret = of_clk_hw_register(np, clk_hw_onecell_data->hws[i]);
- if (ret)
+ if (ret) {
+ kfree(rstc);
return;
+ }
}

meson8b_cpu_nb_data.cpu_clk = clk_hw_onecell_data->hws[CLKID_CPUCLK];
@@ -3727,13 +3730,16 @@ static void __init meson8b_clkc_init_common(struct device_node *np,
if (ret) {
pr_err("%s: failed to register the CPU clock notifier\n",
__func__);
+ kfree(rstc);
return;
}

ret = of_clk_add_hw_provider(np, of_clk_hw_onecell_get,
clk_hw_onecell_data);
- if (ret)
+ if (ret) {
pr_err("%s: failed to register clock provider\n", __func__);
+ kfree(rstc);
+ }
}

static void __init meson8_clkc_init(struct device_node *np)
--
2.26.2
\
 
 \ /
  Last update: 2020-04-29 05:14    [W:0.059 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site