Messages in this thread | | | Date | Wed, 29 Apr 2020 07:34:14 +0800 | From | kbuild test robot <> | Subject | Re: [PATCH v2 2/2] sched: Add a check for cpu unbound deferrable timers |
| |
Hi Prasad,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/timers/core] [also build test ERROR on tip/auto-latest tip/timers/nohz v5.7-rc3 next-20200428] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Prasad-Sodagudi/timer-make-deferrable-cpu-unbound-timers-really-not-bound-to-a-cpu/20200429-060558 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 4479730e9263befbb9ce9563a09563db2acb8f7c config: i386-tinyconfig (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386
If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
kernel/time/timer.c: In function 'run_timer_softirq': >> kernel/time/timer.c:1828:24: error: 'deferrable_pending' undeclared (first use in this function); did you mean 'detach_if_pending'? if ((atomic_cmpxchg(&deferrable_pending, 1, 0) && ^~~~~~~~~~~~~~~~~~ detach_if_pending kernel/time/timer.c:1828:24: note: each undeclared identifier is reported only once for each function it appears in kernel/time/timer.c:1831:18: error: 'timer_base_deferrable' undeclared (first use in this function); did you mean 'timer_base_lock_expiry'? __run_timers(&timer_base_deferrable); ^~~~~~~~~~~~~~~~~~~~~ timer_base_lock_expiry kernel/time/timer.c: In function 'init_timer_deferrable_global': kernel/time/timer.c:2073:2: error: 'timer_base_deferrable' undeclared (first use in this function); did you mean 'timer_base_lock_expiry'? timer_base_deferrable.cpu = nr_cpu_ids; ^~~~~~~~~~~~~~~~~~~~~ timer_base_lock_expiry
vim +1828 kernel/time/timer.c
1817 1818 /* 1819 * This function runs timers and the timer-tq in bottom half context. 1820 */ 1821 static __latent_entropy void run_timer_softirq(struct softirq_action *h) 1822 { 1823 struct timer_base *base = this_cpu_ptr(&timer_bases[BASE_STD]); 1824 1825 __run_timers(base); 1826 if (IS_ENABLED(CONFIG_NO_HZ_COMMON)) { 1827 __run_timers(this_cpu_ptr(&timer_bases[BASE_DEF])); > 1828 if ((atomic_cmpxchg(&deferrable_pending, 1, 0) && 1829 tick_do_timer_cpu == TICK_DO_TIMER_NONE) || 1830 tick_do_timer_cpu == smp_processor_id()) 1831 __run_timers(&timer_base_deferrable); 1832 } 1833 } 1834
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |