lkml.org 
[lkml]   [2020]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 4/4] net: phy: bcm54140: add second PHY ID
From
Date
On 4/28/20 2:08 PM, Michael Walle wrote:
> This PHY have to PHY IDs depending on its mode. Adjust the mask so that
> it includes both IDs.
>
> Also move the PHY_ID_BCM54140 out of the brcmphy.h into the driver to
> have the mask and the ID in one place.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
[snip]

Just one request below.

> diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h
> index 8be150e69c7c..897b69309964 100644
> --- a/include/linux/brcmphy.h
> +++ b/include/linux/brcmphy.h
> @@ -25,7 +25,6 @@
> #define PHY_ID_BCM5461 0x002060c0
> #define PHY_ID_BCM54612E 0x03625e60
> #define PHY_ID_BCM54616S 0x03625d10
> -#define PHY_ID_BCM54140 0xae025019

I would prefer if you could leave the entry here since this the file
that centralizes all Broadcom PHY OUIs.

Thanks!
--
Florian

\
 
 \ /
  Last update: 2020-04-29 00:34    [W:0.341 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site