Messages in this thread | | | Subject | Re: [PATCH net v2 2/2] net: phy: DP83TC811: Fix WoL in config init to be disabled | From | Dan Murphy <> | Date | Tue, 28 Apr 2020 15:59:01 -0500 |
| |
David
On 4/28/20 3:05 PM, David Miller wrote: > From: Dan Murphy <dmurphy@ti.com> > Date: Mon, 27 Apr 2020 16:21:12 -0500 > >> + return phy_write_mmd(phydev, DP83822_DEVADDR, > ^^^^^^^^^^^^^^^^ > > Please don't submit patches that have not even had a conversation with > the compiler. > > This register define only exists in dp83822.c and you are trying to use > it in dp83tc811.c > > If this doesn't compile, how did you do functional testing of this > change?
My fault, I thought my defconfig had this turned on to compile as it did in v1.
I functionally tested these changes on the DP83822 as they are register and feature compatible for WoL
Dan
> If you compile tested these changes against a tree other than the 'net' > tree, please don't do that. > > Thanks.
| |