Messages in this thread | | | Date | Tue, 28 Apr 2020 08:25:09 +0100 | From | Will Deacon <> | Subject | Re: [PATCH] arm64/mm: Reject invalid NUMA option |
| |
On Tue, Apr 28, 2020 at 02:35:20PM +1000, Gavin Shan wrote: > On 4/28/20 1:09 PM, Steven Rostedt wrote: > > [...] > > > > > Could this be a bug in the implementation of strncmp() in > > arch/arm64/lib/strncmp.S. As I don't know arm64 assembly, I have no idea > > what it is trying to do. > > > > But strncmp("o","off",3) returning zero *is* a bug. > > > > I think it's false alarm. The patch has been in my local repo for a while. > I checked out 5.7.rc3 and tried passing "numa=o" to the kernel, @numa_off > is unchanged and its value is false. I also check the return value from > strncmp() as below, it's correct. Nothing is broken. I should have retested > before posting it. Sorry for the noise. Please ignore the crap patch :)
Hmm, it's still worrying that you had that patch kicking around though, as it sounds like it /used/ to be broken. Would you be able to test the LTS kernels (5.4, 4.19, 4.14, 4.9, 4.4) to check that we're not missing a backport, please? Sorry to be a pain, but I'd like to get to the bottom of this!
Thanks,
Will
| |