lkml.org 
[lkml]   [2020]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 011/131] watchdog: reset last_hw_keepalive time at start
    Date
    From: Tero Kristo <t-kristo@ti.com>

    [ Upstream commit 982bb70517aef2225bad1d802887b733db492cc0 ]

    Currently the watchdog core does not initialize the last_hw_keepalive
    time during watchdog startup. This will cause the watchdog to be pinged
    immediately if enough time has passed from the system boot-up time, and
    some types of watchdogs like K3 RTI does not like this.

    To avoid the issue, setup the last_hw_keepalive time during watchdog
    startup.

    Signed-off-by: Tero Kristo <t-kristo@ti.com>
    Reviewed-by: Guenter Roeck <linux@roeck-us.net>
    Link: https://lore.kernel.org/r/20200302200426.6492-3-t-kristo@ti.com
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/watchdog/watchdog_dev.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
    index e64aa88e99dab..10b2090f3e5e7 100644
    --- a/drivers/watchdog/watchdog_dev.c
    +++ b/drivers/watchdog/watchdog_dev.c
    @@ -264,6 +264,7 @@ static int watchdog_start(struct watchdog_device *wdd)
    if (err == 0) {
    set_bit(WDOG_ACTIVE, &wdd->status);
    wd_data->last_keepalive = started_at;
    + wd_data->last_hw_keepalive = started_at;
    watchdog_update_worker(wdd);
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2020-04-28 20:59    [W:4.343 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site