lkml.org 
[lkml]   [2020]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 091/168] iio: xilinx-xadc: Fix ADC-B powerdown
    Date
    From: Lars-Peter Clausen <lars@metafoo.de>

    commit e44ec7794d88f918805d700240211a9ec05ed89d upstream.

    The check for shutting down the second ADC is inverted. This causes it to
    be powered down when it should be enabled. As a result channels that are
    supposed to be handled by the second ADC return invalid conversion results.

    Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
    Fixes: bdc8cda1d010 ("iio:adc: Add Xilinx XADC driver")
    Cc: <Stable@vger.kernel.org>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/iio/adc/xilinx-xadc-core.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/drivers/iio/adc/xilinx-xadc-core.c
    +++ b/drivers/iio/adc/xilinx-xadc-core.c
    @@ -722,13 +722,14 @@ static int xadc_power_adc_b(struct xadc
    {
    uint16_t val;

    + /* Powerdown the ADC-B when it is not needed. */
    switch (seq_mode) {
    case XADC_CONF1_SEQ_SIMULTANEOUS:
    case XADC_CONF1_SEQ_INDEPENDENT:
    - val = XADC_CONF2_PD_ADC_B;
    + val = 0;
    break;
    default:
    - val = 0;
    + val = XADC_CONF2_PD_ADC_B;
    break;
    }


    \
     
     \ /
      Last update: 2020-04-28 20:42    [W:2.222 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site