lkml.org 
[lkml]   [2020]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 080/168] geneve: use the correct nlattr array in NL_SET_ERR_MSG_ATTR
    Date
    From: Sabrina Dubroca <sd@queasysnail.net>

    [ Upstream commit 9a7b5b50de8a764671ba1800fe4c52d3b7013901 ]

    IFLA_GENEVE_* attributes are in the data array, which is correctly
    used when fetching the value, but not when setting the extended
    ack. Because IFLA_GENEVE_MAX < IFLA_MAX, we avoid out of bounds
    array accesses, but we don't provide a pointer to the invalid
    attribute to userspace.

    Fixes: a025fb5f49ad ("geneve: Allow configuration of DF behaviour")
    Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/geneve.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/geneve.c
    +++ b/drivers/net/geneve.c
    @@ -1207,7 +1207,7 @@ static int geneve_validate(struct nlattr
    enum ifla_geneve_df df = nla_get_u8(data[IFLA_GENEVE_DF]);

    if (df < 0 || df > GENEVE_DF_MAX) {
    - NL_SET_ERR_MSG_ATTR(extack, tb[IFLA_GENEVE_DF],
    + NL_SET_ERR_MSG_ATTR(extack, data[IFLA_GENEVE_DF],
    "Invalid DF attribute");
    return -EINVAL;
    }

    \
     
     \ /
      Last update: 2020-04-28 20:41    [W:4.210 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site