lkml.org 
[lkml]   [2020]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 074/167] net: ethernet: ixp4xx: Add error handling in ixp4xx_eth_probe()
    Date
    From: Tang Bin <tangbin@cmss.chinamobile.com>

    [ Upstream commit 6ed79cec3ced6e346a10a70120fcee5f03591bab ]

    The function ixp4xx_eth_probe() does not perform sufficient error
    checking after executing devm_ioremap_resource(), which can result
    in crashes if a critical error path is encountered.

    Fixes: f458ac479777 ("ARM/net: ixp4xx: Pass ethernet physical base as resource")
    Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
    Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/xscale/ixp4xx_eth.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c
    +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
    @@ -1387,6 +1387,8 @@ static int ixp4xx_eth_probe(struct platf
    return -ENODEV;
    regs_phys = res->start;
    port->regs = devm_ioremap_resource(dev, res);
    + if (IS_ERR(port->regs))
    + return PTR_ERR(port->regs);

    switch (port->id) {
    case IXP4XX_ETH_NPEA:

    \
     
     \ /
      Last update: 2020-04-28 20:30    [W:2.112 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site